Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix presence test to produce an error when it's not a map or a message #922

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Fix presence test to produce an error when it's not a map or a message #922

merged 1 commit into from
Apr 16, 2024

Conversation

l46kok
Copy link
Collaborator

@l46kok l46kok commented Apr 15, 2024

AFAICT, attribute qualification already handles presence tests for expected types, so the default case is not needed.

@l46kok l46kok merged commit 2337cc0 into google:master Apr 16, 2024
2 checks passed
@l46kok l46kok deleted the fix-invalid-selection branch April 16, 2024 16:53
@mtaufen mtaufen mentioned this pull request Apr 26, 2024
Closed
3 tasks
@TristonianJones TristonianJones mentioned this pull request Apr 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TristonianJones TristonianJones TristonianJones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l46kok @TristonianJones